Skip to content

all.sh: fail if a file is missing on a "not grep ..." line #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gilles-peskine-arm wants to merge 2 commits into
base: main
Choose a base branch
from
Open

all.sh: fail if a file is missing on a "not grep ..." line #268

gilles-peskine-arm wants to merge 2 commits into from
+37 −0

Conversation

@gilles-peskine-arm
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm commented Jan 9, 2026 •
edited
Loading

Fixes #266

This is transparent since not grep automatically redirects to the new function. I'm not sure whether this should be transitional or if we should keep this automation.

Needs preceding PR: Mbed-TLS/mbedtls#10559, Mbed-TLS/mbedtls#10562, #268 to fix the problems that this reveals.

PR checklist

  • TF-PSA-Crypto PR provided # | not required because: transparent change
  • development PR provided # | not required because: transparent change
  • 3.6 PR provided # | not required because: transparent change

@gilles-peskine-arm
all.sh: fail if a file is missing on a "not grep ..." line
499674d 
Fixes Mbed-TLS#266

Automatically redirect `not grep ...` calls to the new function `not_grep`
which insists that the return code of `grep` is 1 (not found) and not
2 or more (error such as a missing file).

Signed-off-by: Gilles Peskine <[email protected]>
@gilles-peskine-arm gilles-peskine-arm added needs-ci Needs to pass CI tests priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most) labels Jan 9, 2026
@gilles-peskine-arm gilles-peskine-arm added the needs-preceding-pr Requires another PR to be merged first label Jan 9, 2026
mpg
mpg previously approved these changes Jan 13, 2026
View reviewed changes
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mpg
Copy link
Contributor

mpg commented Jan 13, 2026

This is transparent since not grep automatically redirects to the new function. I'm not sure whether this should be transitional or if we should keep this automation.

I think this is nice and should stay, as it avoids a possibility of error.

@mpg
Copy link
Contributor

mpg commented Jan 13, 2026

The latest test run has failures in the following components:

tf-psa-crypto:
tf_psa_crypto_build_custom_config_file

tls-development:
test_full_block_cipher_psa_dispatch_static_keystore
test_full_no_ccm_star_no_tag

tls-mbedtls-3.6:
test_aesni
test_aesni_m32

I'm going to raise PRs for each of them.

This was referenced Jan 13, 2026
Merged
Merged
Open
@gilles-peskine-arm
Support piping into not_grep
076016b 
Signed-off-by: Gilles Peskine <[email protected]>
@gilles-peskine-arm gilles-peskine-arm removed the needs-preceding-pr Requires another PR to be merged first label Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpg mpg mpg left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

needs-ci Needs to pass CI tests priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most)

Projects

Non-roadmap pull requests
Status: In Development

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

all.sh: improve fragile not grep idiom

2 participants

@gilles-peskine-arm @mpg